Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor vertex buffer setting to bundle the bindings on Metal #2307

Closed
kvark opened this issue Aug 10, 2018 · 0 comments
Closed

Refactor vertex buffer setting to bundle the bindings on Metal #2307

kvark opened this issue Aug 10, 2018 · 0 comments
Labels
backend: Metal difficulty: average platform: OSX status: ready for work type: optimization value: low

Comments

@kvark
Copy link
Member

kvark commented Aug 10, 2018

Binding vertex buffers happens fairly often, and we are still using single-buffer binding there. Need to refactor the code to bind all vertex buffers at once.
@kvark kvark mentioned this issue Aug 16, 2018
Merged
4 tasks
bors bot added a commit that referenced this issue Aug 16, 2018
@bors @kvark
Merge #2325
b2b3f8a 
2325: [mtl] New vertex binding logic r=grovesNL a=kvark

Fixes #2324
Fixes #2307
Fixes #2058 (unrelated to the PR, but harmless)

PR checklist:
- [ ] `make` succeeds (on *nix)
- [x] `make reftests` succeeds
- [x] tested examples with the following backends: metal
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors bors bot closed this as completed in #2325 Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend: Metal difficulty: average platform: OSX status: ready for work type: optimization value: low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kvark