Determine GPU type on DX11 when possible #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
kvark
approved these changes
Nov 28, 2020
|
Added 👍 |
Diggsey
force-pushed
the
dx11-detect-gpu-type
branch
from
4ca7131
to
5077757
Compare
Diggsey
changed the title
cwfitzgerald
requested changes
Nov 28, 2020
Diggsey
force-pushed
the
dx11-detect-gpu-type
branch
from
5077757
to
a99099f
Compare
|
Updated |
cwfitzgerald
approved these changes
Nov 28, 2020
Diggsey
force-pushed
the
dx11-detect-gpu-type
branch
from
a99099f
to
c2c960b
Compare
|
Thanks! bors r+ |
|
@Diggsey please make the same PR against |
bors bot
added a commit
that referenced
this pull request
Nov 30, 2020
3485: Enable vulkan debug markers in release builds r=kvark a=fintelia Fixes #3482 (at least for the Vulkan backend) PR checklist: - [x] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: 3492: Determine GPU type on DX11 when possible r=kvark a=Diggsey Cherry pick #3490 to master Co-authored-by: Jonathan Behrens <fintelia@gmail.com> Co-authored-by: Diggory Blake <diggsey@googlemail.com>
bors bot
added a commit
that referenced
this pull request
Dec 1, 2020
3485: Enable vulkan debug markers in release builds r=kvark a=fintelia Fixes #3482 (at least for the Vulkan backend) PR checklist: - [x] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: 3492: Determine GPU type on DX11 when possible r=kvark a=Diggsey Cherry pick #3490 to master 3493: [master/dx11] Increase max bound descriptor set count r=kvark a=cwfitzgerald Rolls up #3487 now that wgpu is targeting master! Should be the last major rollup I need to do! Woooo! I looked at #3449 again but I don't think master needs that change, it looks correct. Co-authored-by: Jonathan Behrens <fintelia@gmail.com> Co-authored-by: Diggory Blake <diggsey@googlemail.com> Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #3489
From what I can tell there's no way to discover this via the DX11 APIs, so guess based on the vendor and device IDs. This can be expanded on later, but initially I've just set it to guess "integrated" for Intel GPUs and "discrete" for everything else, which probably covers >90% of the cases where this applies...