[GL] Android emulator support #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
Gordon-F
commented
Jan 15, 2021
Gordon-F
force-pushed
the
android_emulator_support
branch
from
a54390c
to
0ae506b
Compare
|
@kvark I think I fixed all suggestions. Thank you for reviewing! |
kvark
reviewed
Jan 16, 2021
src/backend/gl/src/window/egl.rs
Outdated
| .make_current(inner.display, None, None, Some(inner.context)) | ||
| .unwrap(); | ||
| if let Some(pbuffer) = inner.pbuffer { | ||
| inner |
There was a problem hiding this comment.
do we actually need this if? couldn't we just pass make_current(inner.display, inner.pbuffer, inner.pbuffer, ..) right away?
There was a problem hiding this comment.
Removed if and checked on the emulator and device. Everything is working fine.
Gordon-F
force-pushed
the
android_emulator_support
branch
from
0ae506b
to
41d2c5f
Compare
|
Sweet!
Bors r+
… On Jan 16, 2021, at 15:32, Igor Shaposhnik ***@***.***> wrote:
@Gordon-F commented on this pull request.
In src/backend/gl/src/window/egl.rs:
> @@ -285,10 +298,23 @@ impl hal::Instance<crate::Backend> for Instance {
fn enumerate_adapters(&self) -> Vec<hal::adapter::Adapter<crate::Backend>> {
let inner = self.inner.lock();
- inner
- .egl
- .make_current(inner.display, None, None, Some(inner.context))
- .unwrap();
+ if let Some(pbuffer) = inner.pbuffer {
+ inner
Removed if and checked on the emulator and device. Everything is working fine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
Android emulator doesn't support EGL_KHR_surfaceless_context.