Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of the input #4309

Closed
kvark opened this issue Nov 4, 2020 · 4 comments
Closed

Validation of the input #4309

kvark opened this issue Nov 4, 2020 · 4 comments
Labels
area: naga front-end help wanted Contributions encouraged kind: feature New feature or request lang: GLSL OpenGL Shading Language naga Shader Translator

Comments

@kvark
Copy link
Member

kvark commented Nov 4, 2020

Unlike GLSL and SPIR-V, for WGSL there is no other validator people could use. So it would be nice to be able to validate the sources completely, as an option that would presumably be enabled in debug mode by the user. Similar feature is already there in GLSL.

@kvark kvark added kind: feature New feature or request help wanted Contributions encouraged area: naga front-end labels Nov 4, 2020
@JCapucho
Copy link
Collaborator

@kvark I think we can close this since the validator now is frontend agnostic

@kvark
Copy link
Member Author

kvark commented May 24, 2021

To clarify, when filing this issue we knew we'd be validating everything in the IR. The question about input validation is separate though, and it still stands. I.e. should the GLSL frontend have extra logic to detect if the incoming GLSL is valid to start with? Previously, @pjoe expressed interest in providing this logic.

@jimblandy
Copy link
Member

Since WGSL is covered, I'm removing the "lang: WGSL" label. Please correct if I've misunderstood.

@cwfitzgerald cwfitzgerald added the lang: GLSL OpenGL Shading Language label Oct 25, 2023
@cwfitzgerald cwfitzgerald transferred this issue from gfx-rs/naga Oct 25, 2023
@cwfitzgerald cwfitzgerald added the naga Shader Translator label Oct 25, 2023
@teoxoy
Copy link
Member

teoxoy commented Nov 2, 2023

I think we can close this, we have IR validation and also front-end specific validation for things not present in the IR.

@teoxoy teoxoy closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: naga front-end help wanted Contributions encouraged kind: feature New feature or request lang: GLSL OpenGL Shading Language naga Shader Translator
Projects
None yet
Development

No branches or pull requests

5 participants