Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl-out: vector bitcast #1405

Merged
merged 1 commit into from Sep 21, 2021
Merged

wgsl-out: vector bitcast #1405

merged 1 commit into from Sep 21, 2021

Conversation

DDoS
Copy link
Contributor

@DDoS DDoS commented Sep 20, 2021

Bitcasting a vector to a vector is valid according to the WGSL spec: https://www.w3.org/TR/WGSL/#bitcast-expr

The current wgsl-out code generates an unsigned-integer-to-float conversion expression when compiling uintBitsToFloat(uvec3), instead of the expected bitcast.

@JCapucho
Copy link
Collaborator

Run cargo test to update the snapshot tests and them to the PR

Copy link
Collaborator

@JCapucho JCapucho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@JCapucho JCapucho merged commit 42db646 into gfx-rs:master Sep 21, 2021
@DDoS DDoS deleted the vector-bitcast branch September 28, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants