Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insert/extractBits and Pack/Unpack #1449

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

cwfitzgerald
Copy link
Member

Implements the following functions for all frontends and all backends (except hlsl... cause ugh).

  • extractBits
  • insertBits
  • pack4x8snorm
  • pack4x8unorm
  • pack2x16snorm
  • pack2x16unorm
  • pack2x16float
  • unpack4x8snorm
  • unpack4x8unorm
  • unpack2x16snorm
  • unpack2x16unorm
  • unpack2x16float

Should there be tests for some/all of these, if so, how should I go about adding them.

@cwfitzgerald cwfitzgerald force-pushed the Add-bit-and-packing branch 2 times, most recently from 9a332f2 to ddca2ac Compare October 5, 2021 20:11
@cwfitzgerald
Copy link
Member Author

There's a stack size error on the 1.43.0 tests, no idea how to fix that.

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a tests/in/bits.wgsl with all these?

@cwfitzgerald cwfitzgerald force-pushed the Add-bit-and-packing branch 5 times, most recently from 5d8715b to a718e7b Compare October 5, 2021 23:28
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

src/proc/typifier.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants