Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wgsl-in] Handle modf and frexp #2454

Merged
merged 3 commits into from
Sep 2, 2023

Conversation

fornwall
Copy link
Contributor

@fornwall fornwall commented Aug 23, 2023

Fixes #1161 (also closes #594 & closes #1441).

A bit rough, will check it more thoroughly, but opening it for feedback.

Moves __atomic_compare_exchange_result<{kind:?},{width}> to the new special_types as it probably fits in there (and gets rid of a TODO comment).

@fornwall fornwall force-pushed the modf-and-frexp-structs branch 7 times, most recently from 620acef to b7d86e3 Compare August 29, 2023 18:33
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great stuff!

src/front/type_gen.rs Outdated Show resolved Hide resolved
src/front/type_gen.rs Outdated Show resolved Hide resolved
src/front/type_gen.rs Outdated Show resolved Hide resolved
src/back/wgsl/writer.rs Outdated Show resolved Hide resolved
src/back/hlsl/help.rs Show resolved Hide resolved
fornwall and others added 2 commits September 1, 2023 23:59
Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
@fornwall fornwall requested a review from teoxoy September 1, 2023 23:32
@teoxoy teoxoy merged commit 5329aa2 into gfx-rs:master Sep 2, 2023
9 checks passed
@fornwall fornwall deleted the modf-and-frexp-structs branch September 3, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change frexp and modf to work with structures Figure out modf story
2 participants