Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming processor, used for [msl] #268

Merged
merged 1 commit into from Nov 11, 2020
Merged

Naming processor, used for [msl] #268

merged 1 commit into from Nov 11, 2020

Conversation

kvark
Copy link
Member

@kvark kvark commented Nov 11, 2020

Fixes #264
The idea is having a global registry of names, to avoid collisions. We fill it up as a separate step before writing down Module contents, so that during writing we only need to look up those names in a created map.

@kvark kvark requested a review from Napokue November 11, 2020 05:54
Copy link
Contributor

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review.

Checker summary (by rust_clippy):
The tool has found 1 warnings, 1 errors.

Copy link
Collaborator

@Napokue Napokue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! I only have two minor comments.

src/proc/namer.rs Outdated Show resolved Hide resolved
src/proc/namer.rs Outdated Show resolved Hide resolved
@kvark
Copy link
Member Author

kvark commented Nov 11, 2020

Thanks for the review! I believe I addressed the comments, also tested this a bit and found one more thing I fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do something about reserved keywords in metal
2 participants