Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaking descriptor sets #99

Closed
kvark opened this issue Jun 21, 2018 · 0 comments
Closed

Leaking descriptor sets #99

kvark opened this issue Jun 21, 2018 · 0 comments
Labels
bug good first issue help wanted

Comments

@kvark
Copy link
Member

kvark commented Jun 21, 2018

When we allocate descriptor sets (in gfxAllocateDescriptorSets) we wrap each of them into Handle. If they are freed, we properly unbox them. But if the pool is reset, we only call the backend reset method, but not actually bothering to go through our owned descriptor sets to unbox them.
This was referenced Jun 25, 2018
Closed
Merged
bors bot added a commit that referenced this issue Jun 25, 2018
@bors @kvark
Merge #106
0764227 
106: Fix descriptor set leak r=grovesNL a=kvark

Fixes #99 

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors bors bot closed this as completed in #106 Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kvark