Derive serialization for the types in spirv-headers #125
Conversation
Added serde as a optional dependency in spirv-header, and feature gated derive for all enums and structs.
There was a problem hiding this comment.
Nice!
The tricky thing here is if a client wants only one side of it (i.e. serialization but not deserialization), they wouldn't be able to do it, and we wouldn't be able to release a breaking version because spirv-headers tries to follow semver of spirv itself...
FYI, wanting only serialization is a thing that, for example, Firefox uses for some of the logic in release, because deserialization just takes so much more time to compile :(
|
@antiagainst could you take a look please? |
Added 2 separate features for Serialize and Deserialize, also added Cargo.lock changes.
|
@kvark Is it good now? |
|
Yes, that's more future-proof, thanks! Please make sure the path is CI tested. |
|
@kvark I am not sure that error in CI is caused by my commits. |
|
indeed! filed #126 |
| [lib] | ||
| path = "lib.rs" | ||
|
|
||
| [dependencies] | ||
| bitflags = "1" | ||
| num-traits = "0.2" | ||
| serde = {version = "1", optional = true, features = ["derive"]} |
There was a problem hiding this comment.
note that this isn't correct, feature should be serde_derive, or the version needs to be more specific
|
@antiagainst how do we get this out for users? |
|
@kvark: I see we might want more breaking changes along the way so it's better to sort out the versioning issue. I'm thinking maybe it's better to retire the current spirv_header crate and instead publish to spirv crate so that we have a chance to detach the spec version and the crate version. @neon64 asked me previously in #21 but back then we don't have a clear need to make it worthwhile. Now maybe its the time. |
|
I haven't given it a lot of thought, tbh. It sounded to me, based on the previous discussions, that relying on upstream Spec semantic versioning can be a problem. In this case, yes, we have to detach it. Do you own "spirv" crate now? Sounds like a good plan :) |
Based on #123
Added serde as a optional dependency in spirv-header,
and feature gated derive for all enums and structs.