New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to upstream SPIR-V 1.5.2 #132
Conversation
Looks like I can't add reviews but @antiagainst and @kvark should look at this. |
Thank you, that looks like an outstanding piece of work! |
Remove extra dbg! statements.
Looks like |
I think there may be a bit more work to do - it's a pretty big change in a mostly unfamiliar codebase so an extra pair of eyes would definitely help, but I think I have a significant part of it covered. Do we have some kind of automated test suite to test against? |
@Jasper-Bekkers do you exist on the Matrix for a short chat, e.g. on #gfx:matrix.org?
Therefore, there is hardly anyone to help you land these changes and review them (with respect to DR/SR parts), unfortunately (sorry!). |
@antiagainst how do you feel about spirv-headers being moved out to the Khronos github organization? |
Thanks @kvark for making me a maintainer of this project. I too mostly use it for spirv-headers and have done the last two updates now to new versions of SPIR-V so I think it makes a lot of sense. I've been developing a bit against this version of the library and I haven't run into any oddities at least. Would be good to get some eyes on this and #133 and then merge them in and publish a new version. |
Ignore spirv::Op::ModuleProcessed in the loader
Since I'm starting to get PRs to my fork of this work, I think I'll go ahead and merge this to mainline to prevent fork-of-fork situations. If anyone objects, feel free to reach out to me or revert the PR. |
This removes the internal version of spirv.core.grammar.json and switches to use only the upstream one spirv.core.grammar.json file as discussed in #116 as a potential better way forward.
This also updates all the bindings to SPIR-V 1.5.2