Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan UPDATE_AFTER_BIND usage Unsound #3335

Closed
cwfitzgerald opened this issue Dec 26, 2022 · 0 comments · Fixed by #3397
Closed

Vulkan UPDATE_AFTER_BIND usage Unsound #3335

cwfitzgerald opened this issue Dec 26, 2022 · 0 comments · Fixed by #3397
Labels
api: vulkan Issues with Vulkan area: correctness We're behaving incorrectly type: bug Something isn't working
Milestone

Comments

@cwfitzgerald
Copy link
Member

Description

Currently we use UPDATE_AFTER_BIND to allow us to raise the limits on vk/intel/windows of images and buffers to reasonable levels (1600 -> 1,000,000).

This is unfortunately unsound as if a descriptor set has any dynamic offsets in it, it cannot be labeled as update after bind.

We have two options:

  • Explicitly add UPDATE_AFTER_BIND-ness to the api (under a different name)
  • Disable the UPDATE_AFTER_BIND workaround entirely.

Because we are going to be switching to DX12 soon, and this only affects windows/intel drivers not linux/intel, we should just scrap the workaround.

@cwfitzgerald cwfitzgerald added type: bug Something isn't working area: correctness We're behaving incorrectly api: vulkan Issues with Vulkan labels Dec 26, 2022
@cwfitzgerald cwfitzgerald added this to the Release 0.15 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vulkan Issues with Vulkan area: correctness We're behaving incorrectly type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant