Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image binding array support #4313

Open
kvark opened this issue Jan 30, 2021 · 2 comments
Open

Image binding array support #4313

kvark opened this issue Jan 30, 2021 · 2 comments
Labels
area: naga front-end help wanted Contributions encouraged kind: feature New feature or request lang: GLSL OpenGL Shading Language naga Shader Translator

Comments

@kvark
Copy link
Member

kvark commented Jan 30, 2021

It would be nice to support this, since wgpu-core does, and one of the wgpu-rs examples uses this.
Example GLSL:

layout(set = 0, binding = 0) uniform texture2D u_Textures[2];

cc @cwfitzgerald
@kvark kvark added kind: feature New feature or request help wanted Contributions encouraged lang: SPIR-V Vulkan's Shading Language area: naga front-end area: naga back-end Outputs of naga shader conversion area: naga middle-end Intermediate representation labels Jan 30, 2021
@teoxoy
Copy link
Member

teoxoy commented Apr 29, 2022

Since gfx-rs/naga#1845 got merged we now support this in all backends and the WGSL frontend.

Remaining work would be GLSL and SPIR-V frontends.

@teoxoy teoxoy added lang: GLSL OpenGL Shading Language and removed area: naga back-end Outputs of naga shader conversion area: naga middle-end Intermediate representation labels Apr 29, 2022
@teoxoy teoxoy changed the title Image array support Image binding array support Apr 29, 2022
@Patryk27
Copy link
Contributor

Patryk27 commented Jan 6, 2023

fyi, I've got something working for the SPIR-V frontend - I'll try submitting the patch tomorrow 🙂

@Patryk27 Patryk27 mentioned this issue Jan 7, 2023
Merged
@teoxoy teoxoy removed the lang: SPIR-V Vulkan's Shading Language label Jan 25, 2023
@cwfitzgerald cwfitzgerald added the naga Shader Translator label Oct 25, 2023
@cwfitzgerald cwfitzgerald transferred this issue from gfx-rs/naga Oct 25, 2023
@teoxoy teoxoy mentioned this issue Nov 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: naga front-end help wanted Contributions encouraged kind: feature New feature or request lang: GLSL OpenGL Shading Language naga Shader Translator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kvark @Patryk27 @cwfitzgerald @teoxoy