Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic when hitting wgpu-core only paths on webgpu backend #5187

Closed
Wumpf opened this issue Feb 2, 2024 · 2 comments
Closed

Don't panic when hitting wgpu-core only paths on webgpu backend #5187

Wumpf opened this issue Feb 2, 2024 · 2 comments
Labels
api: webgpu Issues with direct interface with WebGPU area: api Issues related to API surface

Comments

@Wumpf
Copy link
Member

Wumpf commented Feb 2, 2024

Currently, all methods that require a native feature will always lead to panic on the WebGPU backend. This is unlike other errors (including lacking features on wgpu-core!) which are funneled through the error callbacks, meaning it's impossible to ignore these errors on WebGPU

Describe the solution you'd like
Ideally, we'd use the same mechanism and invoke the error callbacks. They are right now directly set on the backend so this might would need some additional book-keeping.

Describe alternatives you've considered
Technically we could return a result for all of these cases, but that would make error handling awfully inconsistent.

@Wumpf Wumpf added area: api Issues related to API surface api: webgpu Issues with direct interface with WebGPU labels Feb 2, 2024
@cwfitzgerald
Copy link
Member

Duplicate of #3675

@cwfitzgerald cwfitzgerald marked this as a duplicate of #3675 Feb 2, 2024
@cwfitzgerald cwfitzgerald closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Feb 2, 2024

Ah thx, searched but didn't find it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: webgpu Issues with direct interface with WebGPU area: api Issues related to API surface
Projects
None yet
Development

No branches or pull requests

2 participants