Skip to content

Commit

Permalink
revert 'char[] file' to 'char* file' on perl < 5.9
Browse files Browse the repository at this point in the history
Prior commit ad2a648 changed 'char *'
to 'const char*' to match blead.  This broke 5.8.X, which expected a
non- constant file pointer in newXS.  Subsequent iterations had logic
that used 'const char*' for 5.9+ and 'char[]' for earlier perls, but
this broke mod_perl, which expects file to be an assignable pointer.

This commit reverts back to the 'char *' style used in perl 5.8.X.
This should finally put RT#48104 to bed.
  • Loading branch information
xdg committed Oct 3, 2009
1 parent 13abf3d commit 253272c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/ExtUtils/ParseXS.pm
Expand Up @@ -988,7 +988,7 @@ EOF
#so `file' is unused
print Q(<<"EOF") if $Full_func_name;
##if (PERL_REVISION == 5 && PERL_VERSION < 9)
# char file[] = __FILE__;
# char* file = __FILE__;
##else
# const char* file = __FILE__;
##endif
Expand Down

0 comments on commit 253272c

Please sign in to comment.