Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No-arguments rebase proceeds even if there's no upstream set #127

Closed
zombiezen opened this issue Oct 18, 2020 · 0 comments
Closed

No-arguments rebase proceeds even if there's no upstream set #127

zombiezen opened this issue Oct 18, 2020 · 0 comments
Labels
bug Something isn't working
Milestone
1.1

Comments

@zombiezen
Copy link
Member

Steps to Reproduce

Run gg rebase with no arguments on a branch without an upstream.

Expected Behavior

gg should exit with an error message and otherwise do nothing.

Actual Behavior

gg appears to try the rebase.

Version Info

gg version 1.0.2-3, built on 2020-09-05T20:57:10Z
go: go1.14.7 gc linux/amd64
git version 2.20.1
@zombiezen zombiezen added the bug Something isn't working label Oct 18, 2020
@zombiezen zombiezen added this to the 1.1 milestone Oct 18, 2020
zombiezen added a commit that referenced this issue Dec 23, 2020
@zombiezen
Merge tag 'v1.1.0' into debian
59c2f88 
Version 1.1 is the second stable release of gg and includes new commands,
improved `gg branch` output, simpler GitHub integration, and a Homebrew formula.

 ### Added

-  New `addremove` command that adds new files and removes missing ones.
   ([#95](#95))
-  gg has a new command, `github-login`, which obtains a GitHub authorization
   token using a CLI-based OAuth flow. ([#122](#122))
-  `branch` has a new `--sort` flag to control the sort order.
-  gg can now be installed via [Homebrew][]! See https://gg-scm.io/install for
   instructions.

[Homebrew]: https://brew.sh/

 ### Changed

-  `branch` shows the commit hash, author, and summary for each branch.
-  `branch` now sorts by descending commit date by default.
   ([#101](#101))

 ### Fixed

-  `status` and `branch` now display color on Windows.
   ([#125](#125))
-  Released binaries are smaller: they no longer contain debug information.
   ([#121](#121))
-  `commit --amend` no longer exits with an error if the commit contains a
   rename. ([#129](#129))
-  `rebase` displays a simpler error message if the `-dst` argument doesn't
   exist. ([#127](#127))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
1.1
Development

No branches or pull requests
1 participant
@zombiezen