Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 98: When plotting individual plot for report, make sure list is not ggpmx… #141

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

tynesjo
Copy link
Collaborator

@tynesjo tynesjo commented Oct 24, 2020

The reported error #98 was found to generally apply to any npage single integer value.

The problem was caused by an unlisting of the ggplot object which was not contained in a list length 1.

@tynesjo tynesjo force-pushed the 98-pmx-report-failed-with-npage-1 branch from 288b2b8 to 6dc4181 Compare April 22, 2021 18:29
@tynesjo tynesjo force-pushed the 98-pmx-report-failed-with-npage-1 branch from 6dc4181 to d5f2b3c Compare April 22, 2021 18:31
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

Merging #141 (d5f2b3c) into master (a90662b) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   70.15%   70.11%   -0.04%     
==========================================
  Files          45       45              
  Lines        3866     3868       +2     
==========================================
  Hits         2712     2712              
- Misses       1154     1156       +2     
Impacted Files Coverage Δ
R/pmx-plots-individual.R 72.09% <0.00%> (-3.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a90662b...d5f2b3c. Read the comment docs.

@tynesjo tynesjo merged commit 2bc9f49 into master Apr 22, 2021
@tynesjo tynesjo deleted the 98-pmx-report-failed-with-npage-1 branch April 22, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants