Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rounding to fix lines of individual plot when finegrid=FALSE #227

Conversation

tynsci
Copy link
Collaborator

@tynsci tynsci commented May 20, 2022

Fixes #200

  • see comments in issue before merging (assumes that predictions$TIME values are always rounded)

@codecov-commenter
Copy link

Codecov Report

Merging #227 (3277bdd) into master (e39847f) will increase coverage by 0.03%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   71.72%   71.76%   +0.03%     
==========================================
  Files          45       45              
  Lines        3983     3988       +5     
==========================================
+ Hits         2857     2862       +5     
  Misses       1126     1126              
Impacted Files Coverage Δ
R/nlmixr.R 66.66% <66.66%> (-0.99%) ⬇️
R/plot-individual.R 92.18% <100.00%> (+0.06%) ⬆️
R/plot-residual.R 83.75% <0.00%> (+3.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8564bba...3277bdd. Read the comment docs.

@mattfidler mattfidler merged commit c390eec into ggPMXdevelopment:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pmx_plot_individual: line not plotted until last time point when NOT using finegrid
3 participants