Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring match.call parameter passing has symbol evaluation #236

Merged

Conversation

tynsci
Copy link
Collaborator

@tynsci tynsci commented May 23, 2022

Fixes #150

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #236 (17197ae) into master (6e6cb9b) will increase coverage by 0.08%.
The diff coverage is 77.50%.

❗ Current head 17197ae differs from pull request most recent head 2cb99a0. Consider uploading reports for the commit 2cb99a0 to get more accurate results

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   71.23%   71.32%   +0.08%     
==========================================
  Files          45       45              
  Lines        4009     4017       +8     
==========================================
+ Hits         2856     2865       +9     
+ Misses       1153     1152       -1     
Impacted Files Coverage Δ
R/pmx-plots-scatter.R 53.84% <53.84%> (ø)
R/pmx-plots-quantile.R 60.00% <60.00%> (-3.64%) ⬇️
R/pmx-all-plots.R 79.03% <92.30%> (+4.52%) ⬆️
R/pmx-plots-density.R 100.00% <100.00%> (ø)
R/pmx-plots-distibution.R 100.00% <100.00%> (ø)
R/pmx-plots-eta-cov.R 100.00% <100.00%> (ø)
R/pmx-plots-individual.R 73.80% <100.00%> (+1.71%) ⬆️
R/pmx-plots-matrix.R 100.00% <100.00%> (ø)
R/pmx-plots-vpc.R 100.00% <100.00%> (ø)
R/pmx-reader.R 43.84% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e6cb9b...2cb99a0. Read the comment docs.

@mattfidler mattfidler merged commit af0a203 into ggPMXdevelopment:master May 26, 2022
@mattfidler
Copy link
Collaborator

Great!!! LGTM

@biethbr1 biethbr1 mentioned this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot see the variables in the parent scope (ie in functions) but only in global scope
3 participants