Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builtin types #12

Merged
merged 17 commits into from Aug 29, 2020
Merged

Builtin types #12

merged 17 commits into from Aug 29, 2020

Conversation

ggabriel96
Copy link
Owner

@ggabriel96 ggabriel96 commented Aug 29, 2020 •
edited

  • establishes a list of supported ("built-in") types which are the possibilities of a std::variant that is held by Arg to, among other things, support default values
  • std::string is the default type for arguments
  • initial implementation of actions: assign (the default) and append
  • parsing directly builds ArgMap instead of the intermediate ParseResult
  • bumped version number (I always forget to update it :()
  • some code reorganization: split types.hpp into args.hpp and program.hpp

@ggabriel96
First draft version of supporting actions, default arguments and etc:
3d6b9d2 
- removed ParseResult (parsing directly into ArgMap)
- list of supported types in BuiltinTypes
- Arg has std::variant default value member
- Arg stores its action
- implemented very basic assign and append actions
- removed Program::assign_* member functions
- temporarily not assigning default values when setting parsed arguments
- just updated unit tests to pass, gotta re-do them
@ggabriel96
only override action_fn is it was not set by user
9bd15ed
@ggabriel96
Arg is not required by default
a8411d5
@ggabriel96
setting required for positionals
2b48380
@ggabriel96
using actions instead of namespace
3251b59
@ggabriel96
Some code organization:
c3c9a92 
- moved Program to its own .hpp/.cpp files
- types.hpp/.cpp renamed to args.hpp/.cpp, added "section comments"
- opzioni::parsing::parse_option moved to program.hpp, not in parsing namespace anymore
- include cleanup
- removed unused opzioni.cpp and types.test.cpp
@ggabriel96
Removed unused TypedConverter
105d0ce
@ggabriel96
pseudo-random version bump
9dc862c
@ggabriel96
Basic append templated on container too
1899de1
@ggabriel96
testing error messages in parsing.test.cpp
dcfbe0d
@ggabriel96
Usando optional<variant> pro valor padrão
a0d307b
@ggabriel96
Atribuindo valores padrão
097ebee
@ggabriel96
Fix unintentional copy
053ac8e
@ggabriel96
Testing positional argument for command
5af6b5c
@ggabriel96
clang-format
eda336e
@ggabriel96
Fix include guards of args.hpp
55577ae
@ggabriel96
fix typo in comment
b5eb285
@ggabriel96 ggabriel96 added the enhancement New feature or request label Aug 29, 2020
@ggabriel96 ggabriel96 self-assigned this Aug 29, 2020
@ggabriel96 ggabriel96 merged commit c456d5a into main Aug 29, 2020
@ggabriel96 ggabriel96 deleted the builtin-types branch August 29, 2020 18:33
@ggabriel96 ggabriel96 mentioned this pull request Aug 29, 2020
Closed
@ggabriel96 ggabriel96 linked an issue Aug 29, 2020 that may be closed by this pull request
The return of templated Arg? #5
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ggabriel96 ggabriel96

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The return of templated Arg?
1 participant
@ggabriel96