Skip to content

Commit

Permalink
Fixed pointer derefence.
Browse files Browse the repository at this point in the history
Updated tlRender.
  • Loading branch information
ggarra13 committed May 11, 2024
1 parent 38db281 commit 227e4d8
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 17 deletions.
33 changes: 18 additions & 15 deletions mrv2/docs/HISTORY.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,21 @@
v1.1.6
======

This is a release full of goodies.
This is a release full of goodies and bug fixes.

- **ATTENTION**:
This version introduces a change in the way Cache Settings are used for
movie files.
The Settings->Gigabytes and the pair of "Settings->Read Ahead" and
"Settings->Read Behind" are now decoupled.
In the case of sequences, the Read Ahea and Read Behind will be automatically
calculated from the Gigabytes settings as before.
However, for movie files the timeline will only display the settings for
Read Ahead/Behind, not the actual Gigabytes cache (which can be bigger than
the read ahead/behind setting). The small Read Ahead and Read Behind is to
allow playing 4K movies backwards.
The Gigabytes setting of 0 is **NO LONGER USED** and will revert to
4 Gb if set to 0.

- Fixed slow seeking on 4K movies. Now we beat OpenRV on **all** movies,
seeking and reverse playback too.
Expand All @@ -24,19 +38,6 @@ This is a release full of goodies.
and okay'ed while the movie is still playing.
- Fixed seeking on the timeline on Linux sometimes getting the event
incorrectly on X.
- **ATTENTION**:
This version introduces a change in the way Cache Settings are used for
movie files.
The Settings->Gigabytes and the pair of "Settings->Read Ahead" and
"Settings->Read Behind" are now decoupled.
In the case of sequences, the Read Ahea and Read Behind will be automatically
calculated from the Gigabytes settings as before.
However, for movie files the timeline will only display the settings for
Read Ahead/Behind, not the actual Gigabytes cache (which can be bigger than
the read ahead/behind setting). The small Read Ahead and Read Behind is to
allow playing 4K movies backwards.
The Gigabytes setting of 0 is **NO LONGER USED** and will revert to
4 Gb if set to 0.
- Fixed starting a movie with loop on and playing stopped and then start
playing it backwards.
- Refactored playback code and fixed playback buttons sometimes getting out of
Expand All @@ -46,7 +47,9 @@ This is a release full of goodies.
Panels.
- Changing languages now stores and re-loads a session on a temporary location,
so the interface does not reset to 0.
- Made the timeline thumbnails a tad smaller and more polished.
- Made the timeline thumbnail a tad smaller and more polished.
- Fixed a potentially nullptr pointer de-referencing when OpenGL accuracy was
set to Automatic.


v1.1.5
Expand Down
1 change: 1 addition & 0 deletions mrv2/lib/mrvGL/mrvGLViewport.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ namespace mrv
break;
case kAccuracyAuto:
if (!p.videoData[0].layers.empty() &&
p.videoData[0].layers[0].image &&
p.videoData[0].layers[0].image->isValid())
{
const auto& pixelType =
Expand Down
2 changes: 1 addition & 1 deletion mrv2/po/messages.pot
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ msgid ""
msgstr ""
"Project-Id-Version: mrv2 v1.1.6\n"
"Report-Msgid-Bugs-To: ggarra13@gmail.com\n"
"POT-Creation-Date: 2024-05-11 11:44-0300\n"
"POT-Creation-Date: 2024-05-11 13:29-0300\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
Expand Down
2 changes: 1 addition & 1 deletion tlRender

0 comments on commit 227e4d8

Please sign in to comment.