Add interface for changing ggwave's internal logging #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using GGWave::setLogFile() it is now possible to change the log file used internally by ggwave, or disable it all together.
|
Awesome :) I see the global is not protected by a lock, so the function is not threadsafe (not a problem in my usecase), but it would be worthwhile to document it ;) I'm assuming setting it to NULL disables logging all together? |
|
Good point - will add comment that
Correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #51
Using
GGWave::setLogFile()it is now possible to change the log fileused internally by ggwave, or disable it all together.
The
Cinterface function is respectivelyggwave_setLogFile()I guess we can design a better interface in the future, but for now this
seems to be simple enough and does the job.