Windows Fixes. #95
Merged
Windows Fixes. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
reviewed
Jun 13, 2023
.gitmodules
Outdated
| @@ -3,7 +3,7 @@ | |||
| url = https://github.com/ocornut/imgui | |||
| [submodule "examples/third-party/ggsock"] | |||
| path = examples/third-party/ggsock | |||
| url = https://github.com/ggerganov/ggsock | |||
| url = git@github.com:guilt/ggsock.git | |||
There was a problem hiding this comment.
We can first merge the ggsock changes and then keep the submodule pointing to https://github.com/ggerganov/ggsock
|
@ggerganov Please see PR: ggerganov/ggsock#1 |
|
Merged. After we revert the submodule link change we can merge |
guilt
force-pushed
the
master
branch
4 times, most recently
from
571a102
to
bfc12d1
Compare
|
@ggerganov I have made the relevant changes. Please check. I have also updated the comments above on the PR. |
ggerganov
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is primarily just a PR for VC++ on Windows. TL;DR:
ggsockto HEAD forstd::minandstd::maxCMakeLists.txtto make a static lib on Windows (not just MinGW).unistd.handdlfcn.hnot truly part of Windows (MinGW may have it not MSVC).README-tmpl.mdso that whenREADME.mdautogenerates it is not changed per Git.