Support Adept Persimmon 8b #3410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hillip-kravtsov/support-adept-persimmon-8b
…kravtsov/support-adept-persimmon-8b
…kravtsov/support-adept-persimmon-8b
… .saftensors file
…kravtsov/support-adept-persimmon-8b
goerch
reviewed
Sep 30, 2023
…kravtsov/support-adept-persimmon-8b
ggerganov
approved these changes
Oct 2, 2023
phillip-kravtsov
commented
Oct 2, 2023
…kravtsov/support-adept-persimmon-8b
|
Let's resolve the CI fails and merge |
cebtenzzre
reviewed
Oct 5, 2023
…kravtsov/support-adept-persimmon-8b. ggml-ci
phillip-kravtsov
force-pushed
the
phillip-kravtsov/support-adept-persimmon-8b
branch
from
92acb44
to
5d259d3
Compare
ggerganov
reviewed
Oct 6, 2023
…kravtsov/support-adept-persimmon-8b
|
The switches in |
|
@phillip-kravtsov PTAL at @slaren's comment and fix as necessary |
|
I got tired of seeing the compiler warning and created #3535 (not sure if there are any other issues, haven't had a chance to test it yet). |
|
Thanks for the fix @KerfuffleV2 -- that PR should be sufficient. |
joelkuiper
added a commit
to vortext/llama.cpp
that referenced
this pull request
Oct 12, 2023
…example * 'master' of github.com:ggerganov/llama.cpp: py : change version of numpy requirement to 1.24.4 (ggerganov#3515) quantize : fail fast on write errors (ggerganov#3521) metal : support default.metallib load & reuse code for swift package (ggerganov#3522) llm : support Adept Persimmon 8B (ggerganov#3410) Fix for ggerganov#3454 (ggerganov#3455) readme : update models, cuda + ppl instructions (ggerganov#3510) server : docs fix default values and add n_probs (ggerganov#3506)
snichols
pushed a commit
to xgaicc/llama.cpp
that referenced
this pull request
Oct 16, 2023
* Produces garbage output * wip: correct tensors up to RoPE * correct tensors thru RoPE * Correct outputs through masked & softmax'd KQ * fp32 works * Rename adept->persimmon * Produces correct outputs * clean up convert scripts * remove printing logic from ggml.c * remove prints from llama.cpp & fix merge * trivial cleanups * Add offload funcs * update conversion script to directly take adept artifacts rather than .saftensors file * Fix norm eps bug * Support sqr and concat on metal, persimmon-8b-q4 runs correctly * Small changes from review * Formatting changes * Minor changes to conversion script * Remove old script * Fix editorconfig formatting * Fix build * add overlooked offload code ggml-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support Partial RoPE & Squared ReLU, this PR adds concat & square kernels for metal.
I've confirmed agreement between the GGML & HF implementation up to tensor values in the last layer.