(Windows) Set console to UTF-8 on init #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anzz1
requested review from
blackhole89,
ggerganov and
Green-Sky
and removed request for
blackhole89 and
ggerganov
Green-Sky
reviewed
Mar 23, 2023
|
tested on win, LGTM. Considering the previous UTF-8 hack this replaces, I'd say it's better done this way. |
j-f1
reviewed
Mar 23, 2023
Co-authored-by: Jed Fox <git@jedfox.com>
ggerganov
approved these changes
Mar 25, 2023
|
Can merge after conflicts are resolved |
4 tasks
Deadsg
pushed a commit
to Deadsg/llama.cpp
that referenced
this pull request
Dec 19, 2023
Only concatenate after all batches are done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my testing this fixes the problems with UTF-8 inputs and outputs.
I dislike having to add this platform-specific code but it has to be done for it to work properly.
The only other option would be guiding users to go deep into settings to enable a "beta" UTF-8 feature...sigh.
At least is wrapped somewhat nicely as its' own function outside the main loop.