tests: conditional python & node json schema tests #6207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are present Tests introduced in ggerganov#5978 disabled in ggerganov#6198
ochafik
changed the title
ggerganov
approved these changes
Mar 22, 2024
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 1, 2024
* json: only attempt python & node schema conversion tests if their bins are present Tests introduced in ggerganov#5978 disabled in ggerganov#6198 * json: orange warnings when tests skipped * json: ensure py/js schema conv tested on ubuntu-focal-make * json: print env vars in test
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 3, 2024
* json: only attempt python & node schema conversion tests if their bins are present Tests introduced in ggerganov#5978 disabled in ggerganov#6198 * json: orange warnings when tests skipped * json: ensure py/js schema conv tested on ubuntu-focal-make * json: print env vars in test
tybalex
pushed a commit
to tybalex/function.cpp
that referenced
this pull request
Apr 17, 2024
* json: only attempt python & node schema conversion tests if their bins are present Tests introduced in ggerganov#5978 disabled in ggerganov#6198 * json: orange warnings when tests skipped * json: ensure py/js schema conv tested on ubuntu-focal-make * json: print env vars in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs these tests either when python/node is detected (as suggested by @cebtenzzre) or when
LLAMA_PYTHON_AVAILABLE/LLAMA_NODE_AVAILABLEenv var is set (which is done - w/ extra node & python setup - in one test env,ubuntu-focal-make, to guarantee those tests are run somewhere).(tests introduced in #5978 / disabled in #6198 as node/python aren't always there)