Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eval-callback : fix conversion to float #7184

Merged
merged 1 commit into from
May 9, 2024
Merged

eval-callback : fix conversion to float #7184

merged 1 commit into from
May 9, 2024

Conversation

slaren
Copy link
Collaborator

@slaren slaren commented May 9, 2024

eval-callback produced wrong values due to incorrect usage of operator precedence.

@slaren slaren mentioned this pull request May 9, 2024
Closed
cebtenzzre
cebtenzzre approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@cebtenzzre cebtenzzre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is one argument in favor of reinterpret_cast.

@slaren slaren merged commit eaf4bd8 into master May 9, 2024
60 checks passed
@slaren slaren deleted the sl/fix-eval-callback branch May 9, 2024 23:04
@mofosyne mofosyne added bugfix fixes an issue or bug review complexity : low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebtenzzre cebtenzzre cebtenzzre approved these changes

@JohannesGaessler JohannesGaessler JohannesGaessler approved these changes

Assignees
No one assigned
Labels
bugfix fixes an issue or bug review complexity : low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@slaren @cebtenzzre @JohannesGaessler @mofosyne