Revert "move ndk code to a new library" #7282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit efc8f76.
mofosyne
added
build
ggerganov
approved these changes
May 14, 2024
teleprint-me
pushed a commit
to teleprint-me/llama.cpp
that referenced
this pull request
May 17, 2024
) This reverts commit efc8f76.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6951
Was thinking of waiting a day... but actually that might not be a good idea as we got lots of PRs we need to accept.
Plus we already know now that the android PR is not working, so might as well revert and investigate #6951 further in a safe location. He can always make a new PR
Just merge this in if it makes sense to you, once the CI passes