Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un-ignore build-info.cmake and build-info.sh #7996

Merged
merged 5 commits into from
Jun 19, 2024

Commits on Jun 18, 2024

  1. un-ignore build-info.cmake and build-info.sh

    I am assuming that ignoring them was unintentional. If they are ignored, some tools, like cargo, will consider the files inexistent, even if they're comitted, for the purpose of publishing. This leads to the build failing in such cases.
    mdegans committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    840b6ba View commit details
    Browse the repository at this point in the history
  2. un-ignore build-info.cpp.in

    For the same reason as the previous two files.
    mdegans committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    22eedc7 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Reorganize .gitignore

    * Add exceptions for files mentioned by @slaren
    
    I did leave .clang-tidy since it was explicitly ignored before.
    
    * Add comments for organization
    * Sort some lines for pretty
    * Test with `make` and `cmake` builds to ensure no build artifacts might be comitted
    mdegans committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    7f38c03 View commit details
    Browse the repository at this point in the history
  2. Remove .clang-tidy from .gitignore

    Per comment by @ggerganov
    mdegans committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    35f2a46 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    80d4479 View commit details
    Browse the repository at this point in the history