expose api to let user control log output #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I also considered making a log macro that included the |
ggerganov
requested changes
Jul 4, 2023
evmar
force-pushed
the
log
branch
2 times, most recently
from
e4dfbd6
to
a47d489
Compare
Add whisper_set_log_callback() that lets user set a callback for log messages. Change all the fprintf(stderr, ...) to call via the above.
|
OK, I applied your suggestions and rebased. |
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
* expose api to let user control log output Add whisper_set_log_callback() that lets user set a callback for log messages. Change all the fprintf(stderr, ...) to call via the above. * whisper : add <cstdarg> --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
* expose api to let user control log output Add whisper_set_log_callback() that lets user set a callback for log messages. Change all the fprintf(stderr, ...) to call via the above. * whisper : add <cstdarg> --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
landtanin
pushed a commit
to landtanin/whisper.cpp
that referenced
this pull request
Dec 16, 2023
* expose api to let user control log output Add whisper_set_log_callback() that lets user set a callback for log messages. Change all the fprintf(stderr, ...) to call via the above. * whisper : add <cstdarg> --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
whisper_set_log_callback()
that lets user set a callback for log messages.
Change all the
fprintf(stderr, ...)
to call via the above.
This is nice when embedding whisper.cpp into a larger program that doesn't want to print stuff to stderr.