Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CoreML memleak (fixes #1202) #1218

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

denersc
Copy link
Contributor

@denersc denersc commented Aug 28, 2023

Fixes memleak that occurs when calling whisper_full with CoreML (#1202)

@denersc denersc changed the title Fix CoreML leak (fixes #1202) Fix CoreML memleak (fixes #1202) Aug 28, 2023
Copy link
Owner

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helped fix the memory leak in llama.cpp Metal, so I guess it works

@ggerganov ggerganov merged commit 18e9889 into ggerganov:master Aug 29, 2023
34 checks passed
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
vonstring pushed a commit to vonstring/whisper.cpp that referenced this pull request Nov 7, 2023
landtanin pushed a commit to landtanin/whisper.cpp that referenced this pull request Dec 16, 2023
@denersc denersc deleted the fix-coreml-memleak branch January 11, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants