Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whisper.android : fix cmake multiple libraries build #1224

Merged
merged 2 commits into from Aug 30, 2023

Conversation

jhen0409
Copy link
Sponsor Contributor

After #1204, the Android build will only generate two shared libraries which it breaks the previous ABI compatibility:

$ $ANDROID_HOME/cmdline-tools/latest/bin/apkanalyzer files list \
  ~/workspace/whisper.cpp/examples/whisper.android/app/build/outputs/apk/debug/app-debug.apk \
  | grep libwhisper

/lib/armeabi-v7a/libwhisper_vfpv4.so
/lib/arm64-v8a/libwhisper_v8fp16_va.so

After this PR, we can see these are restored:

/lib/x86_64/libwhisper.so
/lib/x86/libwhisper.so
/lib/armeabi-v7a/libwhisper_vfpv4.so
/lib/armeabi-v7a/libwhisper.so
/lib/arm64-v8a/libwhisper_v8fp16_va.so
/lib/arm64-v8a/libwhisper.so

@ggerganov ggerganov merged commit 99d3c10 into ggerganov:master Aug 30, 2023
35 checks passed
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
* whisper.android : fix multiple libraries build

* fix flags for default target
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
* whisper.android : fix multiple libraries build

* fix flags for default target
vonstring pushed a commit to vonstring/whisper.cpp that referenced this pull request Nov 7, 2023
* whisper.android : fix multiple libraries build

* fix flags for default target
landtanin pushed a commit to landtanin/whisper.cpp that referenced this pull request Dec 16, 2023
* whisper.android : fix multiple libraries build

* fix flags for default target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants