Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: Move wav_writer from stream.cpp to common.h #1317

Merged
merged 5 commits into from Oct 3, 2023
Merged

examples: Move wav_writer from stream.cpp to common.h #1317

merged 5 commits into from Oct 3, 2023

Conversation

bobqianic
Copy link
Collaborator

  • The naming convention is to use snake case, so this should be class wav_writer
  • Move to common.h / common.cpp
  • API should be: open(), write(), close()
  • Allocate on the stack instead of on the heap with new and forgetting to deallocate it
  • If params.save_audio is true, call init()

@bobqianic bobqianic marked this pull request as ready for review September 23, 2023 14:19
@ggerganov ggerganov merged commit 08fa348 into ggerganov:master Oct 3, 2023
35 checks passed
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
@bobqianic
examples : move wav_writer from stream.cpp to common.h (ggerganov#1317)
7e5071b 
* Allocate class on the stack instead of on the heap

* Add class wav_writer

* fix some minor issues

* fix some minor issues

* remove potential misleading API
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
@bobqianic
examples : move wav_writer from stream.cpp to common.h (ggerganov#1317)
01746a3 
* Allocate class on the stack instead of on the heap

* Add class wav_writer

* fix some minor issues

* fix some minor issues

* remove potential misleading API
vonstring pushed a commit to vonstring/whisper.cpp that referenced this pull request Nov 7, 2023
@bobqianic @vonstring
examples : move wav_writer from stream.cpp to common.h (ggerganov#1317)
34d02c4 
* Allocate class on the stack instead of on the heap

* Add class wav_writer

* fix some minor issues

* fix some minor issues

* remove potential misleading API
landtanin pushed a commit to landtanin/whisper.cpp that referenced this pull request Dec 16, 2023
@bobqianic
examples : move wav_writer from stream.cpp to common.h (ggerganov#1317)
1cdf2d9 
* Allocate class on the stack instead of on the heap

* Add class wav_writer

* fix some minor issues

* fix some minor issues

* remove potential misleading API
@bobqianic bobqianic deleted the fix branch December 22, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bobqianic @ggerganov