Abort callback improvements #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Oct 8, 2023
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
* whisper : initialize abort_callback to null * whisper : add example how to use abort_callback
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
* whisper : initialize abort_callback to null * whisper : add example how to use abort_callback
vonstring
pushed a commit
to vonstring/whisper.cpp
that referenced
this pull request
Nov 7, 2023
* whisper : initialize abort_callback to null * whisper : add example how to use abort_callback
landtanin
pushed a commit
to landtanin/whisper.cpp
that referenced
this pull request
Dec 16, 2023
* whisper : initialize abort_callback to null * whisper : add example how to use abort_callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
abort_callbackin the following way:nullptr(sorry, I missed that in 2f668c3)main.cppexplaining how to use itAdditionally I have few questions:
encoder_begin_callback? Having two callbacks is quite confusing. Maybe both should be merged? I would be pleased to prepare such change.abort_callbackto these bindings as well?