Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable names in GitHub actions config #1440

Merged
merged 3 commits into from Nov 7, 2023

Conversation

iamthad
Copy link
Contributor

@iamthad iamthad commented Nov 6, 2023

Commit 5fd1bdd renamed some CMake variables from WHISPER_SUPPORT_* to WHISPER_*, but the GitLab Actions config still has the old names.

As a result, the "OpenBLAS-enabled" Windows builds don't actually enable BLAS support.

@bobqianic
Copy link
Collaborator

Nice find! So, this PR reinstates several sanity checks and reveals quite a few problems in the current master branch.

@bobqianic
Copy link
Collaborator

Could you also refresh the OpenBLAS download link to ensure it's the latest version?

For reference, please check: OpenBLAS Releases on GitHub.

image

@iamthad
Copy link
Contributor Author

iamthad commented Nov 7, 2023

I've added a commit that renames the blasdir variable in build.yml to OPENBLAS_PATH, as introduced in #1128. This should fix the "Environment variable OPENBLAS_PATH not defined" error in the build.

@bobqianic
Copy link
Collaborator

bobqianic commented Nov 7, 2023

Do you have any suggestions for a fix? error C2039: 'n_gpu_layers': is not a member of 'llama_context_params' @jhen0409

#1436

if (!params.use_gpu) {
lcparams.n_gpu_layers = 0;
}

@jhen0409
Copy link
Sponsor Contributor

jhen0409 commented Nov 7, 2023

Do you have any suggestions for a fix? error C2039: 'n_gpu_layers': is not a member of 'llama_context_params' @jhen0409

#1436

if (!params.use_gpu) {
lcparams.n_gpu_layers = 0;
}

Ahh I think it may be wrong, n_gpu_layers should be used in lmparams.

UPDATE: #1441

@ggerganov ggerganov merged commit 435a6b7 into ggerganov:master Nov 7, 2023
31 of 35 checks passed
@iamthad iamthad deleted the hotfix/support-variable-names branch November 7, 2023 13:34
vonstring pushed a commit to vonstring/whisper.cpp that referenced this pull request Nov 7, 2023
* Remove _SUPPORT from variables

* Change blasdir to OPENBLAS_PATH

* Update OpenBLAS URLs
felrock pushed a commit to felrock/whisper.cpp that referenced this pull request Nov 18, 2023
* Remove _SUPPORT from variables

* Change blasdir to OPENBLAS_PATH

* Update OpenBLAS URLs
landtanin pushed a commit to landtanin/whisper.cpp that referenced this pull request Dec 16, 2023
* Remove _SUPPORT from variables

* Change blasdir to OPENBLAS_PATH

* Update OpenBLAS URLs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants