New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix variable names in GitHub actions config #1440
Fix variable names in GitHub actions config #1440
Conversation
Nice find! So, this PR reinstates several sanity checks and reveals quite a few problems in the current master branch. |
Could you also refresh the OpenBLAS download link to ensure it's the latest version? For reference, please check: OpenBLAS Releases on GitHub. |
I've added a commit that renames the |
Do you have any suggestions for a fix? error C2039: 'n_gpu_layers': is not a member of 'llama_context_params' @jhen0409 whisper.cpp/examples/talk-llama/talk-llama.cpp Lines 279 to 281 in 0463028
|
Ahh I think it may be wrong, UPDATE: #1441 |
* Remove _SUPPORT from variables * Change blasdir to OPENBLAS_PATH * Update OpenBLAS URLs
* Remove _SUPPORT from variables * Change blasdir to OPENBLAS_PATH * Update OpenBLAS URLs
* Remove _SUPPORT from variables * Change blasdir to OPENBLAS_PATH * Update OpenBLAS URLs
Commit 5fd1bdd renamed some CMake variables from
WHISPER_SUPPORT_*
toWHISPER_*
, but the GitLab Actions config still has the old names.As a result, the "OpenBLAS-enabled" Windows builds don't actually enable BLAS support.