Return with error from whisper_encode_internal and whisper_decode_int… #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernal when abort callback is true
ggerganov
approved these changes
Nov 10, 2023
felrock
pushed a commit
to felrock/whisper.cpp
that referenced
this pull request
Nov 18, 2023
…decode_internal when abort callback is true (ggerganov#1456) Co-authored-by: Ben Nortier <ben@bjnortier.com>
landtanin
pushed a commit
to landtanin/whisper.cpp
that referenced
this pull request
Dec 16, 2023
…decode_internal when abort callback is true (ggerganov#1456) Co-authored-by: Ben Nortier <ben@bjnortier.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding an abort callback the main transcribe function
whisper_full_with_stateaborts the GGML but still continues the main transcription workflow.This pull request will return false from
whisper_encode_internalandwhisper_decode_internalso an abort will return from the main workflow with an error value.