Fixed with_state methods, to use the correct state #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landtanin
pushed a commit
to landtanin/whisper.cpp
that referenced
this pull request
Dec 16, 2023
…1519) Co-authored-by: Sandro Hanea <sandrohanea@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to upgrade https://github.com/sandrohanea/whisper.net to latest whisper.cpp runtime (1.5.0) but discovered that some functions are not working anymore using external provided state.
This is because the context-based state was used in these methods.
If the methods are used from a state call (for parallel transformation using multiple states and same context), errors will arise.
Fix is relatively, simple.
Tested the new build and working as expected with state and searched for all
ctx->stateusages in the whisper.cpp and all of them seems correct now.