Fixed Makefile for MacOS ARM 64 Go bindings #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-metal env var setting
Merged
1 task
|
Looks like this change fixes it for MacOS, but it breaks it for non-MacOS |
|
Fixing it, long time I don't build for linux like this and haven't noticed that -framework works only for MacOS on LLVM. |
|
Done, can you help run the workflows ? |
ggerganov
reviewed
Nov 22, 2023
ggerganov
approved these changes
Nov 22, 2023
|
Thanks !
…On Wed, 22 Nov 2023 at 13:08 Georgi Gerganov ***@***.***> wrote:
Merged #1530 <#1530> into
master.
—
Reply to this email directly, view it on GitHub
<#1530 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAJLMKTZQ52HMLQCFRKUEDYFYPPNAVCNFSM6AAAAAA7TVGUYWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGAZTQNJSHE2DSNY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
landtanin
pushed a commit
to landtanin/whisper.cpp
that referenced
this pull request
Dec 16, 2023
* Fixed Makefile for MacOS ARM 64 based on ggerganov#1344 + proper ggml-metal env var setting * conditional to fix broken non-macos compilation * spaces -> tab * make : fix whitespaces --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Makefile for MacOS ARM 64 based on #1344 + proper ggml-metal env var setting.
Originally it couldn't find includes and the GGML-Metal files as referenced in the issue above and in the main issue for Go bindings #312. Hope that helps.