Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/1748 #1750

Merged
merged 1 commit into from Jan 10, 2024
Merged

fix/1748 #1750

merged 1 commit into from Jan 10, 2024

Conversation

nank1ro
Copy link
Contributor

@nank1ro nank1ro commented Jan 10, 2024

closes #1748

@nank1ro nank1ro mentioned this pull request Jan 10, 2024
Closed
@ggerganov
Copy link
Owner

Did you verify that the examples build and work correctly?
I'm asking because I have some memory that using a commit instead of a branch can cause issues - not really sure though.

@nank1ro
Copy link
Contributor Author

nank1ro commented Jan 10, 2024

Yes just tried on my Mac and on my iPhone and it works

ggerganov
ggerganov approved these changes Jan 10, 2024
View reviewed changes
Copy link
Owner

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ggerganov ggerganov merged commit cc7f872 into ggerganov:master Jan 10, 2024
39 checks passed
@nank1ro nank1ro deleted the fix/1748 branch January 10, 2024 16:12
jiahansu pushed a commit to OOPRY/whisper.cpp that referenced this pull request Apr 17, 2024
@nank1ro @jiahansu
swift : checkout ggml commit instead of branch (ggerganov#1750)
ca46476
viktor-silakov pushed a commit to viktor-silakov/whisper_node_mic.cpp that referenced this pull request May 11, 2024
@nank1ro
swift : checkout ggml commit instead of branch (ggerganov#1750)
28c17db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample SwiftUI app crashes on model load
2 participants
@nank1ro @ggerganov