main : check if input files exist before proceeding #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until the most recent commit (3d42463), the main.cpp sample file does not check whether the input files exist or not. Consequently, the model is loaded first before reporting whether there was a failure or not when processing a file. In environments with HDD, this can take about 50 seconds or more, depending on the loaded model. This commit addresses this issue by checking in advance whether the input files exist or not.
|
A more graceful approach might be to first load the file and then the model. This way, we can leverage |
|
@bobqianic Yes, I do agree with you, but I thought about not doing that in this PR, since main.cpp allows an arbitrary number of wav files, and the user could even run out of memory* before loading the model. Although perhaps this might not be exactly an issue for whisper.cpp users, I'm not sure. (*From what I understood, in the current code, each wav is loaded and then processed, one at a time.) |
ggerganov
approved these changes
Feb 19, 2024
Closed
|
This needs to account for reading from stdin with |
Theldus
added a commit
to Theldus/whisper.cpp
that referenced
this pull request
Feb 22, 2024
In commit dda4b0e of PR ggerganov#1872, I've introduced a check for the existence of files before loading the model. However, I haven't considered the case where whisper.cpp might read from stdin as well, and in such cases, the checks should ignore the "-" argument as it does not represent a regular file. Additionally, this commit removes the usage of 'stat()' in favor of the recently introduced function 'is_file_exist()' in common.cpp from PR ggerganov#1871. Apologies for the bug introduced in the previous PR and any inconvenience it may have caused.
ggerganov
pushed a commit
that referenced
this pull request
Feb 22, 2024
In commit dda4b0e of PR #1872, I've introduced a check for the existence of files before loading the model. However, I haven't considered the case where whisper.cpp might read from stdin as well, and in such cases, the checks should ignore the "-" argument as it does not represent a regular file. Additionally, this commit removes the usage of 'stat()' in favor of the recently introduced function 'is_file_exist()' in common.cpp from PR #1871. Apologies for the bug introduced in the previous PR and any inconvenience it may have caused.
jiahansu
pushed a commit
to OOPRY/whisper.cpp
that referenced
this pull request
Apr 17, 2024
Until the most recent commit (3d42463), the main.cpp sample file does not check whether the input files exist or not. Consequently, the model is loaded first before reporting whether there was a failure or not when processing a file. In environments with HDD, this can take about 50 seconds or more, depending on the loaded model. This commit addresses this issue by checking in advance whether the input files exist or not.
jiahansu
pushed a commit
to OOPRY/whisper.cpp
that referenced
this pull request
Apr 17, 2024
In commit dda4b0e of PR ggerganov#1872, I've introduced a check for the existence of files before loading the model. However, I haven't considered the case where whisper.cpp might read from stdin as well, and in such cases, the checks should ignore the "-" argument as it does not represent a regular file. Additionally, this commit removes the usage of 'stat()' in favor of the recently introduced function 'is_file_exist()' in common.cpp from PR ggerganov#1871. Apologies for the bug introduced in the previous PR and any inconvenience it may have caused.
viktor-silakov
pushed a commit
to viktor-silakov/whisper_node_mic.cpp
that referenced
this pull request
May 11, 2024
Until the most recent commit (3d42463), the main.cpp sample file does not check whether the input files exist or not. Consequently, the model is loaded first before reporting whether there was a failure or not when processing a file. In environments with HDD, this can take about 50 seconds or more, depending on the loaded model. This commit addresses this issue by checking in advance whether the input files exist or not.
viktor-silakov
pushed a commit
to viktor-silakov/whisper_node_mic.cpp
that referenced
this pull request
May 11, 2024
In commit dda4b0e of PR ggerganov#1872, I've introduced a check for the existence of files before loading the model. However, I haven't considered the case where whisper.cpp might read from stdin as well, and in such cases, the checks should ignore the "-" argument as it does not represent a regular file. Additionally, this commit removes the usage of 'stat()' in favor of the recently introduced function 'is_file_exist()' in common.cpp from PR ggerganov#1871. Apologies for the bug introduced in the previous PR and any inconvenience it may have caused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until the most recent commit (3d42463), the main.cpp sample file does not check whether the input files exist or not. Consequently, the model is loaded first before reporting whether there was a failure or not when processing a file. In environments with HDD, this can take about 50 seconds or more, depending on the loaded model.
This PR addresses this by checking in advance whether the input files exist or not.