Stream.wasm: Fix invalid memory access when no segments are returned #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No segments may be returned when a smaller sample buffer (EG 2048 samples) is sent to the worker.
ggerganov
reviewed
Feb 25, 2024
| @@ -103,11 +103,11 @@ void stream_main(size_t index) { | |||
|
|
|||
| { | |||
| const int n_segments = whisper_full_n_segments(ctx); | |||
| for (int i = n_segments - 1; i < n_segments; ++i) { | |||
| const char * text = whisper_full_get_segment_text(ctx, i); | |||
| if (n_segments > 0) { | |||
There was a problem hiding this comment.
This will only process the last segment. We want to process all segments
Suggested change
| if (n_segments > 0) { | |
| for (int i = n_segments - 1; i < n_segments && n_segments > 0; ++i) { |
There was a problem hiding this comment.
single_segment is set to true so it will not output more than one segment. Furthermore, the original code's for loop will only iterate once anyways. Because it starts from n-1 and stops at n-1, it will only process the last segment.
ggerganov
approved these changes
Feb 26, 2024
viktor-silakov
pushed a commit
to viktor-silakov/whisper_node_mic.cpp
that referenced
this pull request
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No segments may be returned when a smaller sample buffer (EG 2048 samples) is sent to the worker. This causes an invalid memory access error as
whisper_full_get_segment_text(ctx, -1)is called.