Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for signedness compiler warning #497

Closed
wants to merge 2 commits into from

Conversation

shikokuchuo
Copy link
Contributor

Eliminates the following compiler warning:

whisper.cpp:3868:55: warning: comparison of integer expressions of different signedness: ‘std::vector<whisper_full(whisper_context*, whisper_full_params, const float*, int)::beam_candidate>::size_type’ {aka ‘long unsigned int’} and ‘int’ [-Wsign-compare]
 3868 |                         while (beam_candidates.size() > cur_c && beam_candidates[cur_c].sequence.sum_logprobs_all == cur.sequence.sum_logprobs_all && i > 0) {
      |                                ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~

gcc 11.3.0 on Ubuntu 22.04 using cmake.

whisper.cpp Outdated Show resolved Hide resolved
Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
@shikokuchuo shikokuchuo deleted the shikokuchuo-patch-1 branch February 15, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants