Skip to content

Commit

Permalink
enable CI tests on php 5.4, 5.5
Browse files Browse the repository at this point in the history
  • Loading branch information
gggeek committed Nov 23, 2022
1 parent 39537aa commit 88374ec
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 6 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/ci.yml
Expand Up @@ -24,17 +24,14 @@ jobs:
# @see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
# @todo fix: atm our tests fail when using ubuntu 20 (focal) and php 5.6 - 7.1, when using
# an ssl stream context for connecting to localhost via https
# @todo ubuntu 18 is deprecated. move to 20
operating-system: ['ubuntu-18.04'] # @todo add 'windows-latest'
# @todo use an older version of phpunit to enable testing on php 5.3 - 5.5 . Also: we will most likely
# have to resort to using shivammathur/setup-php@v2 instead of sury's ppa to get php installed
php: ['8.1', '8.0', '7.4', '7.3', '7.2', '7.1', '7.0', '5.6']
operating-system: ['ubuntu-20.04'] # @todo add 'windows-latest'
# @todo enable testing on php 5.3 - it requires use an older version of phpunit (and no yoast/phpunit-polyfills?)
php: ['8.1', '8.0', '7.4', '7.3', '7.2', '7.1', '7.0', '5.6', '5.5', '5.4']
steps:
-
uses: actions/checkout@v2
# Although this action is useful, we prefer to use the same script to set up php that we use for the
# docker image used for local testing. This allows us to make sure that script is always in good shape
# @todo shivammathur/setup-php@v2 allows us to test with php 5.3 - 5.5 and 8.2. Use it in those cases!
#-
# uses: shivammathur/setup-php@v2
# with:
Expand Down
11 changes: 11 additions & 0 deletions NEWS
@@ -1,3 +1,14 @@
XML-RPC for PHP version xxx - unreleased

* fixed: decoding of responses with latin-1 charset declared in the xml prolog but not in http headers, when on php 5.4, 5.5

* fixed: DateTimeInterface is not present in php 5.4 (error introduced in ver. 4.8.1)

* improved: CI tests now run on php versions 5.4, 5.5 besides all more recent ones

* improved: the test container for local testing now defaults to php 7.4 on ubuntu 20 focal


XML-RPC for PHP version 4.8.1 - 2022/11/10

* improved: remove warnings with php 8.1 due to usage of strftime
Expand Down
1 change: 1 addition & 0 deletions tests/6HTTPTest.php
Expand Up @@ -261,6 +261,7 @@ public function testHttpsSocket($method)

if (version_compare(PHP_VERSION, '5.6.0', '<'))
{
/// @todo investigate: can we make this work?
$this->markTestSkipped('HTTPS via Socket known to fail on php 5.5 and earlier');
return;
}
Expand Down

0 comments on commit 88374ec

Please sign in to comment.