Merge pull request #9 from shiar/main

endless loop following self referential structs
ggicci · Dec 17, 2023 · e3644c4 · e3644c4
2 parents 8fffb3d + 8814d32
commit e3644c4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/resolver.go b/resolver.go
@@ -429,6 +429,9 @@ func buildResolver(typ reflect.Type, field reflect.StructField, parent *Resolver
 			if !field.IsExported() {
 				continue
 			}
+			if field.Type == root.Type {
+				continue
+			}
 
 			child, err := buildResolver(field.Type, field, root)
 			if err != nil {

diff --git a/resolver_test.go b/resolver_test.go
@@ -248,6 +248,14 @@ func TestNew_WithNonStruct(t *testing.T) {
 	assert.ErrorContains(t, err, "non-struct type")
 }
 
+func TestNew_WithRecursion(t *testing.T) {
+	type RecursiveRef struct {
+		Loop *RecursiveRef
+	}
+	_, err := owl.New(RecursiveRef{})
+	assert.NoError(t, err)
+}
+
 func TestNew_ParsingDirectives_InvalidName(t *testing.T) {
 	resolver, err := owl.New(struct {
 		Invalid string `owl:"invalid/name"`