Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

v1.0.1a1 #14

Merged
merged 189 commits into from
Dec 7, 2021
Merged

v1.0.1a1 #14

merged 189 commits into from
Dec 7, 2021

Conversation

ggirelli
Copy link
Owner

@ggirelli ggirelli commented Mar 5, 2021

First release, not alpha.

@ggirelli ggirelli marked this pull request as draft November 1, 2021 21:30
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 7, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.39%.

Quality metrics Before After Change
Complexity 3.09 ⭐ 3.85 ⭐ 0.76 👎
Method Length 49.96 ⭐ 52.06 ⭐ 2.10 👎
Working memory 7.52 🙂 9.42 🙂 1.90 👎
Quality 73.50% 🙂 72.11% 🙂 -1.39% 👎
Other metrics Before After Change
Lines 2252 2539 287
Changed files Quality Before Quality After Quality Change
ifpd2/init.py 97.84% ⭐ 89.76% ⭐ -8.08% 👎
ifpd2/asserts.py 83.30% ⭐ 79.11% ⭐ -4.19% 👎
ifpd2/const.py 100.00% ⭐ 89.83% ⭐ -10.17% 👎
ifpd2/database.py 83.86% ⭐ 76.15% ⭐ -7.71% 👎
ifpd2/logging.py 76.47% ⭐ 73.88% 🙂 -2.59% 👎
ifpd2/oligo.py 77.66% ⭐ 77.48% ⭐ -0.18% 👎
ifpd2/probe.py 71.64% 🙂 69.07% 🙂 -2.57% 👎
ifpd2/probe_set.py 76.25% ⭐ 75.75% ⭐ -0.50% 👎
ifpd2/walker.py 69.48% 🙂 70.02% 🙂 0.54% 👍
ifpd2/walker2.py 93.93% ⭐ 81.01% ⭐ -12.92% 👎
ifpd2/scripts/init.py 87.68% ⭐ 87.02% ⭐ -0.66% 👎
ifpd2/scripts/arguments.py 89.52% ⭐ 87.52% ⭐ -2.00% 👎
ifpd2/scripts/ifpd2.py 86.89% ⭐ 96.18% ⭐ 9.29% 👍
ifpd2/scripts/query.py 62.34% 🙂 44.34% 😞 -18.00% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
ifpd2/scripts/query.py main 6 ⭐ 587 ⛔ 62 ⛔ 27.61% 😞 Try splitting into smaller methods. Extract out complex expressions
ifpd2/probe.py OligoProbeBuilder._assert 22 😞 250 ⛔ 6 ⭐ 45.08% 😞 Refactor to reduce nesting. Try splitting into smaller methods
ifpd2/walker.py GenomicWindowSet.__mk_all_window_sets 5 ⭐ 231 ⛔ 13 😞 46.16% 😞 Try splitting into smaller methods. Extract out complex expressions
ifpd2/walker.py Walker.process_window 4 ⭐ 176 😞 16 ⛔ 47.41% 😞 Try splitting into smaller methods. Extract out complex expressions
ifpd2/walker.py Walker._preprocess_window_do 7 ⭐ 134 😞 15 😞 49.92% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@ggirelli ggirelli changed the title v1.0.1 v1.0.1a1 Dec 7, 2021
@ggirelli ggirelli marked this pull request as ready for review December 7, 2021 08:27
@ggirelli ggirelli merged commit b480240 into main Dec 7, 2021
v1.0.1 automation moved this from In progress to Done Dec 7, 2021
@ggirelli ggirelli deleted the dev branch December 7, 2021 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[REQUEST] New database format with bookmarks and chromosome sizes.
1 participant