Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ggally_count in ggduo and ggpairs discrete plots #340

Merged
merged 2 commits into from
May 30, 2020

Conversation

schloerke
Copy link
Member

@schloerke schloerke commented May 30, 2020

Followup to #321

  • set ggduo's discrete to count
  • set ggpairs's discrete upper to count
  • Currently not setting ggpairs's discrete diagonal to countDiag as diagonals are currently different. barDiag seems to do well given the space provided
  • Using a more-likely to be unique col name (.ggally_y vs .y) when making the factor column in ggally_count

cc @larmarange

@schloerke schloerke merged commit 11e3846 into master May 30, 2020
@schloerke schloerke deleted the larmarange-ggally_count branch May 30, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant