Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve factor ordering in ggscatmat #355

Merged
merged 2 commits into from Jun 1, 2020
Merged

Conversation

schloerke
Copy link
Member

Fixes #329

https://cran.r-project.org/doc/manuals/r-devel/NEWS.html

R now uses a stringsAsFactors = FALSE default, and hence by default no longer converts strings to factors in calls to data.frame() and read.table().

When the stat_density was being added to the plot, the stat_density data was not a factor. This caused the original data to become "un-factored" (which caused the alphabetical sorting).

Now the factor ordering is preserved.

cc @andrewheiss @dicook

@schloerke schloerke added this to the 2.0.0 milestone Jun 1, 2020
@schloerke schloerke merged commit 2cb012c into master Jun 1, 2020
@schloerke schloerke deleted the ggscatmat_placement branch June 1, 2020 16:16
@dicook
Copy link
Member

dicook commented Aug 16, 2020

@schloerke this isn't actually fixed. i'm going to see if i can work it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plots and values inconsistently placed in ggscatmat()
2 participants