Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no colour arg if all values are NA #404

Merged
merged 4 commits into from Mar 7, 2021
Merged

no colour arg if all values are NA #404

merged 4 commits into from Mar 7, 2021

Conversation

larmarange
Copy link
Contributor

If the var_label column is not populated (all values are equal to NA), then do not map colour aesthetic to "var_label" as it will create a problem with ggplot2.

@larmarange
Copy link
Contributor Author

This is a minor change, to account for the future extension of broom.helpers where var_label will not be populated for certain types of models where it is not relevant

@schloerke
Merge branch 'master' into larmarange-ggcoef_fixes
4f0b18e 
* master:
  ignore CRAN-RELEASE
  missing link in documentation (ggobi#403)
  bug fix in stat_cross() (ggobi#402)
@schloerke
Merge branch 'master' into larmarange-ggcoef_fixes
a68ff15 
* master:
  bug fix in ggcoef_model when tidy() does not return a p.value (ggobi#400)
@schloerke
Merge branch 'master' into larmarange-ggcoef_fixes
dd066c0 
* master:
  Suggest `emmeans` (ggobi#407)
@schloerke schloerke merged commit b098ce9 into ggobi:master Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@larmarange @schloerke