-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix no_reference_row option in ggcoeff_compare() #431
Conversation
Waiting for checks |
check errors for windows due to the fact that a new version of igraph was just released and windows binaries are not yet available. |
Hi @schloerke I have updated GitHub actions with last version from https://github.com/r-lib/actions Ubuntu 16 is not anymore available in GitHub actions |
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 91.33% 92.08% +0.75%
==========================================
Files 36 36
Lines 4360 4361 +1
==========================================
+ Hits 3982 4016 +34
+ Misses 378 345 -33
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the GHA updates!!
Nice trick with the {{ var }}
! I don't fully understand it, but pretty cool.
tidy selectors could be tricky. The brakets allow to pass the selectors without evaluating them. Doing so, the evaluation of the selectors will be done in the relevant function, and not before. |
|
Fix #430
Fix #432
Created on 2021-11-10 by the reprex package (v2.0.1)