Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no_reference_row option in ggcoeff_compare() #431

Merged
merged 7 commits into from
Jan 14, 2022

Conversation

larmarange
Copy link
Contributor

@larmarange larmarange commented Nov 10, 2021

Fix #430
Fix #432

library(GGally)
#> Le chargement a nécessité le package : ggplot2
#> Registered S3 method overwritten by 'GGally':
#>   method from   
#>   +.gg   ggplot2

m1 <- glm(smoker ~ day + time + total_bill, data = reshape::tips, family = "binomial")
m2 <- glm(smoker ~ day + time + sex, data = reshape::tips, family = "binomial")

ggcoef_compare(
  list("Model 1"= m1, "Model 2" = m2), 
  type = "faceted", exponentiate = TRUE,
  no_reference_row = broom.helpers::all_dichotomous()
) 

ggcoef_compare(
  list("Model 2"= m2, "Model 1" = m1), 
  type = "faceted", exponentiate = TRUE,
  no_reference_row = broom.helpers::all_dichotomous()
) 

Created on 2021-11-10 by the reprex package (v2.0.1)

@larmarange
Copy link
Contributor Author

Waiting for checks

@larmarange
Copy link
Contributor Author

check errors for windows due to the fact that a new version of igraph was just released and windows binaries are not yet available.

cf. https://cran.r-project.org/package=igraph

@larmarange
Copy link
Contributor Author

Hi @schloerke

I have updated GitHub actions with last version from https://github.com/r-lib/actions

Ubuntu 16 is not anymore available in GitHub actions

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #431 (f7a9670) into master (3918c50) will increase coverage by 0.75%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   91.33%   92.08%   +0.75%     
==========================================
  Files          36       36              
  Lines        4360     4361       +1     
==========================================
+ Hits         3982     4016      +34     
+ Misses        378      345      -33     
Impacted Files Coverage Δ
R/ggcoef_model.R 98.25% <100.00%> (+1.05%) ⬆️
R/ggparcoord.R 96.96% <0.00%> (+10.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8072493...f7a9670. Read the comment docs.

Copy link
Member

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the GHA updates!!

Nice trick with the {{ var }}! I don't fully understand it, but pretty cool.

@schloerke schloerke merged commit 53c1f65 into ggobi:master Jan 14, 2022
@larmarange
Copy link
Contributor Author

Nice trick with the {{ var }}! I don't fully understand it, but pretty cool.

tidy selectors could be tricky. The brakets allow to pass the selectors without evaluating them. Doing so, the evaluation of the selectors will be done in the relevant function, and not before.

@schloerke
Copy link
Member

The brackets allow to pass the selectors without evaluating them
👏👏👏 Fancy

schloerke added a commit to huizezhang-sherry/ggally that referenced this pull request Oct 12, 2022
* master:
  Use `{vdiffr}`; Update GHA; Update "print on CI / examples" method; Fix lints (ggobi#453)
  Fix in `ggcoef_compare()` when using an `include` argument (ggobi#448)
  Fix no_reference_row option in ggcoeff_compare() (ggobi#431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants