scrutinizer

ggoffy · Mar 18, 2021 · 6d3e95a · 6d3e95a
1 parent 6fc58eb
commit 6d3e95a
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/class/Github/GithubClient.php b/class/Github/GithubClient.php
@@ -113,7 +113,7 @@ public function testApi2($url) {
      * @param     $username
      * @param int $per_page
      * @param int $page
-     * @return array
+     * @return array|bool
      */
     public function getUserRepositories($username, $per_page = 100, $page = 1)
     {
@@ -128,7 +128,7 @@ public function getUserRepositories($username, $per_page = 100, $page = 1)
      * @param     $org
      * @param int $per_page
      * @param int $page
-     * @return array
+     * @return array|bool
      */
     public function getOrgRepositories($org, $per_page = 100, $page = 1)
     {
@@ -142,7 +142,7 @@ public function getOrgRepositories($org, $per_page = 100, $page = 1)
      *
      * @param string $username   the user who owns the repository
      * @param string $repository the name of the repository
-     * @return string|array the readme content
+     * @return array|bool
      */
     public function getReadme($username, $repository)
     {
@@ -156,7 +156,7 @@ public function getReadme($username, $repository)
      *
      * @param string $username   the user who owns the repository
      * @param string $repository the name of the repository
-     * @return array
+     * @return array|bool
      */
     public function getReleases($username, $repository)
     {
@@ -171,7 +171,7 @@ public function getReleases($username, $repository)
      * @param string $username   the user who owns the repository
      * @param string $repository the name of the repository
      * @param bool   $prerelease
-     * @return array
+     * @return array|bool
      */
     public function getLatestRelease($username, $repository, $prerelease = false)
     {
@@ -183,11 +183,6 @@ public function getLatestRelease($username, $repository, $prerelease = false)
         }
         $result = $this->_get($url);
 
-        if (\is_array($result) && \array_key_exists('error_code', $result)) {
-            //TODO: improve error handling
-            echo $result['message'];
-            die;
-        }
         if ($prerelease) {
             if (\is_array($result)) {
                 return $result[0];
@@ -204,7 +199,7 @@ public function getLatestRelease($username, $repository, $prerelease = false)
      *
      * @param  $username
      * @param  $repository
-     * @return array
+     * @return array|bool
      */
     public function getRepositoryContent($username, $repository)
     {